Optimize traits.d by factoring out two common sub-expressions when ev…

…aluating the builtin traits isFinalClass and isTemplate
nordlow · Aug 25, 2024 · 2370e2c · 2370e2c
1 parent 90c4145
commit 2370e2c
Showing 1 changed file with 10 additions and 4 deletions.
diff --git a/compiler/src/dmd/traits.d b/compiler/src/dmd/traits.d
@@ -482,13 +482,19 @@ Expression semanticTraits(TraitsExp e, Scope* sc)
     }
     if (e.ident == Id.isAbstractClass)
     {
-        return isTypeX(t => t.toBasetype().isTypeClass() &&
-                            t.toBasetype().isTypeClass().sym.isAbstract());
+        return isTypeX((t)
+        {
+            auto c = t.toBasetype().isTypeClass();
+            return c && c.sym.isAbstract();
+        });
     }
     if (e.ident == Id.isFinalClass)
     {
-        return isTypeX(t => t.toBasetype().isTypeClass() &&
-                            (t.toBasetype().isTypeClass().sym.storage_class & STC.final_) != 0);
+        return isTypeX((t)
+        {
+            const c = t.toBasetype().isTypeClass();
+            return c && (c.sym.storage_class & STC.final_) != 0;
+        });
     }
     if (e.ident == Id.isTemplate)
     {