Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-build-add-bionic-specific-gcc-install-requirement--nmo-585 #583

Conversation

RedLeader962
Copy link
Collaborator

Description

  • Add a bionic-specific dependencies install step
    • Update GCC and G++ alternatives to set version 9 as bionic alternatives.
  • Enable docker compose no-cache option for resetting build cache.
  • Add new TeamCity build script.

Issue NMO-585 and PR #581


Checklist:

Code related

  • I have made corresponding changes to the documentation
    (i.e.: function, class, script header, README.md)
  • I have commented hard-to-understand code
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
    (Check contributing_instructions.md for local testing procedure using libpointmatcher-build-system)

PR creation related

  • My pull request base ref branch is set to the develop branch
    (the build-system won't be triggered otherwise)
  • My pull request branch is up-to-date with the develop branch
    (the build-system will reject it otherwise)

PR description related

  • I have included a quick summary of the changes
  • I have indicated the related issue's id with # <issue-id> if changes are of type fix
  • I have included a high-level list of changes and their corresponding types
    (See commit_msg_reference.md for details)

- Add logic to install GCC 9 for Ubuntu 18.04 in dependency script.
- Replace "ci_PR_arm64v8" with "ci_PR_arm64" in multiple scripts.
- Add TeamCity-specific script to manage build flags and dry-run options.
- Update contributing documentation to reflect architecture label changes.
- Add `sudo apt update` and `software-properties-common` package install before adding PPA.
- Ensure non-interactive package installation with `--assume-yes` flag for `gcc-9` and `g++-9`.

[skip release]
- Added INVALIDATE_CACHE ARG to Dockerfiles and .env for cache invalidation.
- Deleted obsolete JetBrains run configuration.
- Enabled verbose flag for sudo update-ca-certificates for more detailed output.

Issue NMO-585
…ilds

- Set `no_cache: true` in docker-compose files for consistent builds
- Remove `INVALIDATE_CACHE` environment variable and related arguments from Dockerfiles
- Add `software-properties-common` to the general dependency list
- Consolidate commands to remove outdated packages
- Use conditional logic for installing compilers based on Ubuntu version

[skip release]
- Re-added gcc and g++ installation to the base dependencies script.
- Removed redundant installation commands for gcc and g++ in
non-version-specific branch.

Issue NMO-585

[skip release]
…-requirement--nmo-585

# Conflicts:
#	build_system/ubuntu/lpm_install_dependencies_general_ubuntu.bash
- Add command to set GCC and G++ 9 as bionic alternatives

Issue NMO-585 and PR #581
Copy link

sonarcloud bot commented Aug 15, 2024

@RedLeader962 RedLeader962 merged commit bafdda9 into develop Aug 15, 2024
5 of 6 checks passed
@RedLeader962 RedLeader962 mentioned this pull request Aug 15, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants