Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small bug fix to make sure VI has proper inplace support #13

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Small bug fix to make sure VI has proper inplace support #13

merged 1 commit into from
Feb 9, 2024

Conversation

SamDuffield
Copy link
Contributor

@SamDuffield SamDuffield commented Feb 9, 2024 •
edited
Loading

I had previously omitted the inplace argument in the torchopt update

@SamDuffield SamDuffield requested a review from KaelanDt February 9, 2024 12:45
KaelanDt
KaelanDt approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@KaelanDt KaelanDt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@SamDuffield SamDuffield merged commit 0cf5dd7 into main Feb 9, 2024
2 checks passed
@SamDuffield SamDuffield deleted the vi-diag-fix branch February 9, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KaelanDt KaelanDt KaelanDt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamDuffield @KaelanDt