Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Clone, Copy and Debug on possible structs and enums #715

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

musjj
Copy link

@musjj musjj commented Apr 13, 2024

I was really annoyed with getting blocked by some structs not implementing Clone/Copy/Debug so I tried to implement them in as many places as possible (sorry for the fat diff).

There's a block of code that is not compliant with rustfmt, so let's
restore it for now and maybe deal with it in another PR
src/exec.rs Outdated Show resolved Hide resolved
src/telemetry.rs Outdated Show resolved Hide resolved
@musjj
Copy link
Author

musjj commented Apr 14, 2024

Btw, I'm unable to run the tests on my machine for some reason. Even with a fresh unmodified clone of master, I'm getting errors such as:

test coroutine_execution_order ... ok
double free or corruption (out)
error: test failed, to rerun pass `--test coroutine_pause`

The errors seems to be inconsistent between runs, so I'm guessing that there's a race condition somewhere.

Could you run it on your side if possible?

@profan
Copy link
Contributor

profan commented Apr 30, 2024

Btw, I'm unable to run the tests on my machine for some reason. Even with a fresh unmodified clone of master, I'm getting errors such as:

test coroutine_execution_order ... ok
double free or corruption (out)
error: test failed, to rerun pass `--test coroutine_pause`

The errors seems to be inconsistent between runs, so I'm guessing that there's a race condition somewhere.

Could you run it on your side if possible?

Random aside here but this specific test seems to be exploding for me as well, likely everyone right now

@mandroll
Copy link
Contributor

Btw, I'm unable to run the tests on my machine for some reason. Even with a fresh unmodified clone of master, I'm getting errors ...

Random aside here but this specific test seems to be exploding for me as well, likely everyone right now

Documented here: #693

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants