Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BaseCard with differrent css classes #1642

Merged
merged 1 commit into from
Sep 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ describe(BaseCard.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard =
Expand Down
14 changes: 6 additions & 8 deletions packages/frontend/web-ui/src/game/components/BaseCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,12 @@ interface BaseCardOptions {

export const BaseCard = (params: BaseCardOptions) => {
return (
<Box component="div" className="cornie-base-card">
<Box component="div" className="cornie-base-card-inner-border">
<Box
component="div"
className={`cornie-base-card-inner-content ${params.colorClass}`}
>
{params.children}
</Box>
<Box component="div" className="cornie-card">
<Box
component="div"
className={`cornie-card-inner-content ${params.colorClass}`}
>
{params.children}
</Box>
</Box>
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe(DrawCard.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe(ImageCard.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard = cardColor.classList.contains(
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/web-ui/src/game/components/ImageCard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export interface ImageCardOptions {
export const ImageCard = (params: ImageCardOptions) => {
return (
<BaseCard colorClass={params.colorClass}>
<Box component="div" className="cornie-base-card-image">
<Box component="div" className="cornie-card-image">
<img src={params.image} />
</Box>
</BaseCard>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe(NormalCard.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe(ReverseCard.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard =
Expand Down
6 changes: 4 additions & 2 deletions packages/frontend/web-ui/src/game/components/ReversedCard.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
import { Box } from '@mui/material';

export const ReversedCard = (): React.JSX.Element => {
export const ReversedCard = (options?: {
text?: string;
}): React.JSX.Element => {
return (
<Box component="div" className="cornie-card">
<Box component="div" className="cornie-card-inner-border">
Expand Down Expand Up @@ -28,7 +30,7 @@ export const ReversedCard = (): React.JSX.Element => {
</svg>
</Box>
<Box component="div" className="cornie-card-text">
CORNIE
{options?.text ?? 'CORNIE'}
</Box>
</Box>
</Box>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ describe(SkipCard.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe(TextCard.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard = cardColor.classList.contains(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe(WildCard.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard = cardColor.classList.contains(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe(WildDraw4Card.name, () => {
);

const cardColor: HTMLElement = renderResult.container.querySelector(
'.cornie-base-card-inner-content',
'.cornie-card-inner-content',
) as HTMLElement;

isExpectedClassNameInCard = cardColor.classList.contains(
Expand Down
2 changes: 1 addition & 1 deletion packages/frontend/web-ui/src/game/routes/GameRoutes.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { PublicGames } from '../pages/PublicGames';
export const GameRoutes = (): React.JSX.Element => {
return (
<Routes>
<Route path="/" element={<CreateNewGame />} />
<Route path="/create" element={<CreateNewGame />} />
<Route path="/join" element={<JoinExistingGame />} />
<Route path="/public" element={<PublicGames />} />
</Routes>
Expand Down
4 changes: 4 additions & 0 deletions packages/frontend/web-ui/src/scss/base/_variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ $cornie_font: 'Gochi Hand';

// Colors
$black: #000;
$blue: #00f;
$green: #0f0;
$red: #f00;
$yellow: #ff0;
$white: #fff;
$transparent: rgba(0, 0, 0, 0);

Expand Down
92 changes: 61 additions & 31 deletions packages/frontend/web-ui/src/scss/game/components/_card.scss
Original file line number Diff line number Diff line change
@@ -1,44 +1,74 @@
@use '../../base/variables' as variables;

div.cornie-card {
aspect-ratio: 2 / 3;
border: 2px solid var(--cg-bkg-primary-main);
border-radius: 1.5rem;
background-color: variables.$black;
height: 100%;
padding: 0.5rem 0.5rem;
}

div.cornie-card div.cornie-card-inner-border {
border-radius: 1rem;
background-color: var(--cg-bkg-primary-main);
height: 100%;
padding: 0.5rem 0.5rem;
}
div.cornie-card-inner-border {
border-radius: 1rem;
background-color: var(--cg-bkg-primary-main);
height: 100%;
padding: 0.5rem 0.5rem;

div.cornie-card div.cornie-card-inner-content {
background-color: variables.$black;
border-radius: 0.5rem;
display: grid;
height: 100%;
}
div.cornie-card-inner-content {
border-radius: 0.5rem;
}
}

div.cornie-card div.cornie-card-icon {
align-self: end;
padding: 0 1rem;
}
div.cornie-card-inner-content {
background-color: variables.$black;
border-radius: 1rem;
display: grid;
height: 100%;

div.cornie-card div.cornie-card-icon path {
stroke: var(--cg-bkg-primary-light);
}
&.blue-card {
background-color: variables.$blue;
}

&.green-card {
background-color: variables.$green;
}

&.red-card {
background-color: variables.$red;
}

&.yellow-card {
background-color: variables.$yellow;
}

&.white-color {
background-color: variables.$white;
}
}

div.cornie-card-icon {
align-self: end;
padding: 0 1rem;

path {
stroke: var(--cg-bkg-primary-light);
}
}

div.cornie-card-text {
align-self: start;
color: var(--cg-bkg-primary-light);
cursor: default;
font-family: variables.$cornie_font;
font-weight: bold;
font-size: variables.$font-xs;
letter-spacing: 0.3rem;
text-align: center;
user-select: none;
}

div.cornie-card div.cornie-card-text {
align-self: start;
color: var(--cg-bkg-primary-light);
cursor: default;
font-family: variables.$cornie_font;
font-weight: bold;
font-size: variables.$font-sm;
letter-spacing: 0.3rem;
text-align: center;
user-select: none;
div.cornie-card-image {
display: flex;
align-items: center;
justify-content: center;
}
}