Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login hook to relay on rtk query #1708

Merged
merged 8 commits into from
Oct 8, 2024

Conversation

wariofdz
Copy link
Collaborator

@wariofdz wariofdz commented Oct 7, 2024

Added:

  • Added new file createAuthErrorMessages.ts with error message to access auth.
  • Added new function getCreateAuthErrorMessage.ts and his test, to get a error message for auth.

Changed:

  • Modified hook useLoginForm.ts and his test, to use mapUseQueryHookResultV2 and get a better error message.
  • Modified enum LoginStatus.ts to add a new step in the status.

@wariofdz wariofdz self-assigned this Oct 7, 2024
Copy link
Owner

@notaphplover notaphplover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just added an small suggestion.

packages/frontend/web-ui/src/auth/hooks/useLoginForm.ts Outdated Show resolved Hide resolved
@wariofdz wariofdz merged commit 4209daa into master Oct 8, 2024
3 checks passed
@wariofdz wariofdz deleted the refactor/update-Login-hook-to-relay-on-rtk-query branch October 8, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants