Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove .map files in dist/ #50

Closed
wants to merge 4 commits into from

Conversation

Two-Hearts
Copy link
Contributor

The .map files are not required in production.

Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
@Two-Hearts Two-Hearts requested review from duffney, shizhMSFT and a team as code owners January 16, 2024 02:01
@Two-Hearts Two-Hearts changed the title fix: removed .map files in dist/ fix: remove .map files in dist/ Jan 16, 2024
@Two-Hearts Two-Hearts changed the title fix: remove .map files in dist/ chore: remove .map files in dist/ Jan 16, 2024
Copy link

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Two-Hearts Map files are used for printing symbols when there is an error. In other words, how can we debug a user reported error if there is something wrong with the GitHub action? e.g. which line of code is reporting the error?

@Two-Hearts
Copy link
Contributor Author

@Two-Hearts Map files are used for printing symbols when there is an error. In other words, how can we debug a user reported error if there is something wrong with the GitHub action? e.g. which line of code is reporting the error?

@shizhMSFT The check-dist workflow is reporting failures on checking the .map files even though there's no change on them.
An example of not including the .map files in dist/: https://github.com/oras-project/setup-oras/tree/main/dist

@Two-Hearts
Copy link
Contributor Author

Needs further investigation. Close for now.

@Two-Hearts Two-Hearts closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants