Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(signature): add two fuzz tests #229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(signature): add two fuzz tests #229

wants to merge 1 commit into from
+66 −0

Conversation

AdamKorcz
Copy link

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.76%. Comparing base (0786f51) to head (dcf0258).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files          30       30           
  Lines        2065     2065           
=======================================
  Hits         1895     1895           
  Misses        115      115           
  Partials       55       55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

shizhMSFT
shizhMSFT approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT changed the title signature: add two fuzz tests test(signature): add two fuzz tests Sep 20, 2024
JeyJeyGao
JeyJeyGao approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Two-Hearts
Two-Hearts approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

priteshbandi
priteshbandi approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi
Copy link
Contributor

@AdamKorcz can you please sign your commits?

@AdamKorcz
signature: add two fuzz tests
dcf0258 
Signed-off-by: AdamKorcz <[email protected]>
Signed-off-by: Adam Korczynski <[email protected]>
@AdamKorcz
Copy link
Author

@AdamKorcz can you please sign your commits?

It should already be signed by way of git commit -s. Is there another way, I should do it?

@Two-Hearts
Copy link
Contributor

It should already be signed by way of git commit -s. Is there another way, I should do it?

@AdamKorcz The flag -s is for signoff. To fix, please try git commit --amend --no-edit -S --signoff. (note the capital S here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteshbandi priteshbandi priteshbandi approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@JeyJeyGao JeyJeyGao JeyJeyGao approved these changes

@Two-Hearts Two-Hearts Two-Hearts approved these changes

@gokarnm gokarnm Awaiting requested review from gokarnm gokarnm is a code owner

@NiazFK NiazFK Awaiting requested review from NiazFK NiazFK is a code owner

@rgnote rgnote Awaiting requested review from rgnote rgnote is a code owner

@toddysm toddysm Awaiting requested review from toddysm toddysm is a code owner

@vaninrao10 vaninrao10 Awaiting requested review from vaninrao10 vaninrao10 is a code owner

@yizha1 yizha1 Awaiting requested review from yizha1 yizha1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AdamKorcz @priteshbandi @Two-Hearts @shizhMSFT @JeyJeyGao