fix: timestamping #243
Merged
fix: timestamping #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick Zheng <[email protected]>
Two-Hearts
requested review from
gokarnm,
JeyJeyGao,
NiazFK,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
Signed-off-by: Patrick Zheng <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 91.81% 91.79% -0.03%
==========================================
Files 30 30
Lines 2616 2607 -9
==========================================
- Hits 2402 2393 -9
Misses 163 163
Partials 51 51 ☔ View full report in Codecov by Sentry. |
shizhMSFT
requested changes
Nov 6, 2024
Signed-off-by: Patrick Zheng <[email protected]>
Is this true for verification ? |
This PR is for signing only. We will have another PR for verification in notation-go once this PR gets merged. @priteshbandi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to implementation needs, we must provide a
time.Timewhen verifying TSA certificate chain validity after signing. Originally, this time value was taken from the timestamp countersignature envelope itself.This PR switches to use the
current timewhen verifying TSA certificate chain validity since the tsa cert chain is expected to be valid during signing.