Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add initial CODEOWNERS and MAINTAINERS #2

Merged
merged 2 commits into from
May 30, 2023

Conversation

FeynmanZhou
Copy link
Member

@FeynmanZhou FeynmanZhou commented May 16, 2023

Add initial CODEOWNERS and MAINTAINERS per discussion in notaryproject/.github#26. I hope @notaryproject/notaryproject-governance-maintainers @notaryproject/notaryproject-org-maintainers could help to review and approve this PR. Thanks!

@FeynmanZhou FeynmanZhou changed the title add inital CODEOWNERS and MAINTAINERS doc: add initial CODEOWNERS and MAINTAINERS May 16, 2023
MAINTAINERS Outdated Show resolved Hide resolved
CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@Two-Hearts Two-Hearts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FeynmanZhou FeynmanZhou requested a review from toddysm May 17, 2023 15:56
Copy link

@cipherboy cipherboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if I'm supposed to ACK this or not, but my details look good and as I've mentioned to Feynman in a mail, happy to help review designs and code to the project!

Copy link

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit d9af48e into notaryproject:main May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants