Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add license header to files and github action workflow to check license #739

Merged
merged 6 commits into from
Jul 18, 2023

Conversation

Two-Hearts
Copy link
Contributor

@Two-Hearts Two-Hearts commented Jul 12, 2023

Resolves #706

This PR should be reviewed/merged after notaryproject/notation-core-go#154.

@Two-Hearts Two-Hearts self-assigned this Jul 12, 2023
@Two-Hearts Two-Hearts added the enhancement New feature or request label Jul 12, 2023
@Two-Hearts Two-Hearts added this to the 1.0.0 milestone Jul 12, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #739 (0015e5f) into main (a685f69) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   63.66%   63.66%           
=======================================
  Files          40       40           
  Lines        2232     2232           
=======================================
  Hits         1421     1421           
  Misses        690      690           
  Partials      121      121           
Impacted Files Coverage Δ
cmd/notation/cert/add.go 64.91% <ø> (ø)
cmd/notation/cert/cmd.go 100.00% <ø> (ø)
cmd/notation/cert/delete.go 35.71% <ø> (ø)
cmd/notation/cert/generateTest.go 64.51% <ø> (ø)
cmd/notation/cert/list.go 52.43% <ø> (ø)
cmd/notation/cert/show.go 31.66% <ø> (ø)
cmd/notation/common.go 100.00% <ø> (ø)
cmd/notation/inspect.go 68.63% <ø> (ø)
cmd/notation/internal/cmdutil/confirmation.go 83.33% <ø> (ø)
cmd/notation/internal/errors/errors.go 0.00% <ø> (ø)
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

shizhMSFT
shizhMSFT previously approved these changes Jul 12, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

test/e2e/run.sh Show resolved Hide resolved
@Two-Hearts Two-Hearts changed the title feat: add license header to files and github action workflow to check license chore: add license header to files and github action workflow to check license Jul 12, 2023
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
Signed-off-by: Patrick Zheng <[email protected]>
priteshbandi
priteshbandi previously approved these changes Jul 12, 2023
Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shizhMSFT
shizhMSFT previously approved these changes Jul 13, 2023
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This PR must be merged after notaryproject/notation-core-go#154

Signed-off-by: Patrick Zheng <[email protected]>
JeyJeyGao
JeyJeyGao previously approved these changes Jul 18, 2023
Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Patrick Zheng <[email protected]>
Copy link
Contributor

@shizhMSFT shizhMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@JeyJeyGao JeyJeyGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@priteshbandi priteshbandi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priteshbandi priteshbandi merged commit 57a0a6e into notaryproject:main Jul 18, 2023
@Two-Hearts Two-Hearts deleted the license branch July 19, 2023 02:36
@shizhMSFT shizhMSFT mentioned this pull request Jul 21, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check the license header for Notation and its dependencies
5 participants