Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unsupported block types from the list of currently supported #80

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

anonymousRecords
Copy link
Member

Description of Changes

Here is reference: #25


remove unsupported block types from the list of currently supported

  • Currently, for all collection-related Notion block types, the Enum is set to collection_view, which indicates a need for more specific Block Type Enums. (Please refer to attached photo)
  • After checking the official Notion API, we confirmed that Collections are not supported as block concepts in the Notion API.
  • In our meeting, it was decided that we plan to support Collections in the future, so I've updated the documentation to reflect this.
  • Also updated this information in the Supported Notion Block Types Progress issue.

Review point

  • I've already removed the collection-related items from the markdown file, but I'm curious about your opinion on whether we need a separate note or explanation for this removal. What do you think?

Copy link
Contributor

@Moon-DaeSeung Moon-DaeSeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Moon-DaeSeung Moon-DaeSeung merged commit f5806fd into main Oct 20, 2024
@Moon-DaeSeung Moon-DaeSeung deleted the update/notion-block-types-list branch October 20, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants