Add support for unicode in SSIDs and PSKs #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The corresponding c code for encoding and decoding them can be found in wpa_supplicant/src/utils/common.c printf_decode escapes a SSID for returning in scan results wpa_config_parse_string reads a string from the config or the socket. It might be nicer to use the printf encoded P"I \xf0\x9f\xa6\x80 rust" style but I could not find a decent encoder.
|
There are probably still issues as it is possible to have an SSID that is not valid unicode, but I don't know support that without breaking the API. I did not check the access point side of things so it is possible that there are more places there that need to deal with encoding better. I feel slightly dirty overriding clippy about using actual tabs in the example in the doc test. Let me know if there are any issue or changes you would like. |
Add helper methods for reading a line from the socket, and for sending a request and waiting for the response.
It adds a debug log message if there is no listener for the boradcasts.
This is to allow the runner to keep going if there is an issue with any single response from the wpa_supplicant
This replaces the INI config parser from the config crate with a simplified parser that only support k=v pairs, but does proper printf unsecaping for non printable/on ASCII characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding c code for encoding and decoding them can be found in wpa_supplicant/src/utils/common.c
printf_decode escapes a SSID for returning in scan results
wpa_config_parse_string reads a string from the config or the socket. It might be nicer to use the printf encoded P"I \xf0\x9f\xa6\x80 rust" style but I could not find a decent encoder.