Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it easier for downstream to modify settings #1428

Merged
merged 5 commits into from
Oct 9, 2024
Merged

Make it easier for downstream to modify settings #1428

merged 5 commits into from
Oct 9, 2024

Conversation

CendioOssman
Copy link
Member

Expose a simple and stable API to override default settings, and force settings that users shouldn't be able to change.

Fixes #1159.

@CendioOssman CendioOssman added this to the v1.2.0 milestone Jun 26, 2020
samhed
samhed reviewed Jun 26, 2020
View reviewed changes
Copy link
Member

@samhed samhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@samhed samhed mentioned this pull request Jun 26, 2020
Closed
@CendioOssman
Copy link
Member Author

I just realised this isn't going to work with use_require.js. So either that needs to be fixed somehow, or we have to wait until we can drop Internet Explorer and require module support.

Putting this on hold for now.

@CendioOssman CendioOssman modified the milestones: v1.2.0, Future Features Jun 29, 2020
@CendioOssman CendioOssman marked this pull request as draft June 29, 2020 12:11
@CendioOssman
Copy link
Member Author

So #1477 is now up, so we just need to wait for that.

@tculp
Copy link

tculp commented Apr 19, 2021

Bump because this would be very useful and #1477 is now merged

@CendioOssman
Copy link
Member Author

It's still on my todo, but I'm unsure when I'll have time to finish this.

@CendioOssman
Handle all settings via UI.getSetting()
9334c68 
Makes sure everything behaves the same way, even if there is no visible
UI for a settings.
@CendioOssman
Merge UI startup in to a single routine
c6606a5 
Makes it easier to see how things are connected.
@CendioOssman
Handle disabling settings without label
84897fd
@CendioOssman CendioOssman force-pushed the ui_init branch 2 times, most recently from 951795c to 3bef61e Compare August 8, 2024 14:24
@CendioOssman CendioOssman marked this pull request as ready for review August 8, 2024 14:26
@samhed samhed modified the milestones: Future Features, v1.6.0 Oct 3, 2024
samhed
samhed requested changes Oct 3, 2024
View reviewed changes
Copy link
Member

@samhed samhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, this is a nice improvement!

I tested both setting stuff in vnc.html and in the defaults.json/mandatory.json, things work as expected as long as you clear the web storage inbetween, or use a private-browsing tab.

app/ui.js Show resolved Hide resolved
app/ui.js Outdated Show resolved Hide resolved
vnc.html Show resolved Hide resolved
defaults.json Show resolved Hide resolved
@CendioOssman
Make it easier for downstream to modify settings
438e5b3 
Expose a simple and stable API to override default settings, and force
settings that users shouldn't be able to change.
@CendioOssman
Load settings from web server
28d4020 
Make it even easier to customize things by loading the settings from
separate configuration files.
@CendioOssman
Copy link
Member Author

Hmm... It looks like the tests are broken on master. Something with the new H.264 code. Open a new issue and ping the author(s) of that code?

samhed
samhed approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@samhed samhed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Hmm... It looks like the tests are broken on master. Something with the new H.264 code. Open a new issue and ping the author(s) of that code?

I'll open a new issue.

@samhed samhed mentioned this pull request Oct 9, 2024
Open
@CendioOssman CendioOssman merged commit ed1fef4 into novnc:master Oct 9, 2024
9 of 11 checks passed
@CendioOssman CendioOssman deleted the ui_init branch October 9, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhed samhed samhed approved these changes

Assignees
No one assigned
Labels
feature ui/full
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

make it easier to customize default host, password, port in the url via code
3 participants
@CendioOssman @tculp @samhed