Feature [RM75] Character Card #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using the term "tiles" now using "cards"
wrumble
reviewed
Aug 11, 2021
Comment on lines
25
to
27
| private let cornerRadius: CGFloat = 10 | ||
| private let noSpacing: CGFloat = 0 | ||
| private let VSpacing: CGFloat = 10 |
There was a problem hiding this comment.
Id probably extract these into their own private constants struct. Something we do on Glovo which i quite like, except they use an enum which i dont like.
private struct Constants {
let cornerRadius: CGFloat = 10
let noSpacing: CGFloat = 0
let VSpacing: CGFloat = 10
}
then id add the other magic numbers dotted around to it too like on line 43, 67 &70
Comment on lines
55
to
59
| VStack(alignment: .leading, spacing: noSpacing) { | ||
| Text("First seen in:") | ||
| .font(.caption) | ||
| .foregroundColor(.secondary) | ||
| Text(characterCardState.firstEpisode) |
There was a problem hiding this comment.
The duplication here could be extracted to a function. I havent played with SwiftUI to know enough but roughly along the lines of:
func characterDetailsVStack(pretext: String, details: String) -> VStack {
return VStack(alignment: .leading, spacing: noSpacing) {
Text(pretext)
.font(.caption)
.foregroundColor(.secondary)
Text(details)
}
then called:
characterDetailsVStack(pretext: "Last known location:", details: characterCardState.lastLocation)
characterDetailsVStack(pretext: "First seen in:", details: characterCardState.firstEpisode)
There was a problem hiding this comment.
Id maybe even consider putting those strings as constants too, or prep them for localisation 🤷
Comment on lines
77
to
88
| VStack { | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: false, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| } | ||
| .preferredColorScheme(.light) | ||
| VStack { | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: false, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| } | ||
| .preferredColorScheme(.dark) |
There was a problem hiding this comment.
Theres duplication here, try and use my above example to see what functions you can create for the VStack and CharacterCard duplications :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/novoda/projects/1#card-66556830
Built a character card displaying an image and relevant data about a character.