Feature [RM75] Character Card #76
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "2.jpeg", | ||
| "idiom" : "universal", | ||
| "scale" : "1x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "2x" | ||
| }, | ||
| { | ||
| "idiom" : "universal", | ||
| "scale" : "3x" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "author" : "xcode", | ||
| "version" : 1 | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,92 @@ | ||
| // | ||
| // CharacterTileView.swift | ||
| // Rick And Morty | ||
| // | ||
| // Created by Scottie Gray on 2021-08-10. | ||
| // Copyright © 2021 Novoda. All rights reserved. | ||
| // | ||
|
|
||
| import SwiftUI | ||
| import Foundation | ||
|
|
||
| struct CharacterCardState { | ||
| var id: Int | ||
| var name: String | ||
| var image: UIImage | ||
| var isAlive: Bool | ||
| var species: String | ||
| var lastLocation: String | ||
| var firstEpisode: String | ||
| } | ||
|
|
||
| struct CharacterCard: View { | ||
| var characterCardState: CharacterCardState | ||
|
|
||
| private let cornerRadius: CGFloat = 10 | ||
| private let noSpacing: CGFloat = 0 | ||
| private let VSpacing: CGFloat = 10 | ||
|
|
||
| var body: some View { | ||
| HStack(alignment: .top) { | ||
| Image(uiImage: characterCardState.image) | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
|
|
||
| VStack(alignment: .leading, spacing: VSpacing) { | ||
| VStack(alignment: .leading, spacing: noSpacing) { | ||
| Text(characterCardState.name) | ||
| .font(.title) | ||
| .fontWeight(.black) | ||
| HStack { | ||
| Circle() | ||
| .foregroundColor(characterCardState.isAlive ? .green : .red) | ||
| .frame(width: 10, height: 10) | ||
| Text(characterCardState.isAlive ? "Alive - \(characterCardState.species)" : "Dead - \(characterCardState.species)") | ||
| } | ||
| } | ||
|
|
||
| VStack(alignment: .leading, spacing: noSpacing) { | ||
| Text("Last known location:") | ||
| .font(.caption) | ||
| .foregroundColor(.secondary) | ||
| Text(characterCardState.lastLocation) | ||
| } | ||
|
|
||
| VStack(alignment: .leading, spacing: noSpacing) { | ||
| Text("First seen in:") | ||
| .font(.caption) | ||
| .foregroundColor(.secondary) | ||
| Text(characterCardState.firstEpisode) | ||
|
There was a problem hiding this comment. The duplication here could be extracted to a function. I havent played with SwiftUI to know enough but roughly along the lines of: then called: There was a problem hiding this comment. Id maybe even consider putting those strings as constants too, or prep them for localisation 🤷 |
||
| } | ||
| } | ||
| Spacer() | ||
| } | ||
| .cornerRadius(cornerRadius) | ||
| .overlay( | ||
| RoundedRectangle(cornerRadius: cornerRadius) | ||
| .stroke(Color(.lightGray), lineWidth: 0.25) | ||
| ) | ||
| .padding() | ||
| .frame(height: 200) | ||
| } | ||
| } | ||
|
|
||
| struct CharacterTileView_Previews: PreviewProvider { | ||
| static var previews: some View { | ||
| Group { | ||
| VStack { | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: false, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| } | ||
| .preferredColorScheme(.light) | ||
| VStack { | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: false, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| CharacterCard(characterCardState: CharacterCardState(id: 2, name: "Morty", image: UIImage(named: "morty-image")!, isAlive: true, species: "Human", lastLocation: "Earth", firstEpisode: "Episode 1")) | ||
| } | ||
| .preferredColorScheme(.dark) | ||
|
There was a problem hiding this comment. Theres duplication here, try and use my above example to see what functions you can create for the VStack and CharacterCard duplications :) |
||
|
|
||
| } | ||
| } | ||
| } | ||
File renamed without changes.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Id probably extract these into their own private constants struct. Something we do on Glovo which i quite like, except they use an enum which i dont like.
then id add the other magic numbers dotted around to it too like on line 43, 67 &70