fix: add domain parser hook and domain condition #5413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
SokratisVidros
approved these changes
Apr 16, 2024
There was a problem hiding this comment.
@jainpawan21 I approve this so that we can ship but PTAL at my comments. I think it's worth using the validate function.
| @@ -161,12 +174,6 @@ export function QuestionnaireForm() { | |||
| <Controller | |||
| name="domain" | |||
| control={control} | |||
| rules={{ | |||
There was a problem hiding this comment.
Alternatively, we can add it as a custom rule and let it trigger as part of react-hook-form lifecycle. For example:
rules = {{
validate: {
isValidDomain: v => parse(v)...
}
}}```
For more information PTAL https://www.react-hook-form.com/api/useform/register/#options:~:text=%7D%0A/%3E-,validate,-Function%20%7C%20Object
I am not sure what other benefits this gives us but If I had to guess it would make it simpler to trigger all validations at once on form click or maybe on blur if we want to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Add
useDomainParserHookhandle invalid domain field value
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer