Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add visibility for CORS processing #5420

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

antonjoel82
Copy link
Contributor

What changed? Why was the change needed?

  • Add logging to gain visibility on why CORS error is still occurring for Deploy Previews

Screenshots

Expand for optional sections

Special notes for your reviewer

  • Are there any concerns logging the information included in the context?

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit a12688a
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/661ed6523f87620008ded81c
😎 Deploy Preview https://deploy-preview-5420--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit a12688a
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/661ed652ee23690008ad7d5c
😎 Deploy Preview https://deploy-preview-5420--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antonjoel82 antonjoel82 marked this pull request as ready for review April 16, 2024 19:51
@Cliftonz Cliftonz merged commit 49bb545 into next Apr 16, 2024
27 of 28 checks passed
@Cliftonz Cliftonz deleted the deploy-preview-cors branch April 16, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants