Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mobile condition with modal #5432

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

jainpawan21
Copy link
Member

What changed? Why was the change needed?

hide modal in mobile so that user is not blocked
replace useEffect from get started page to modal component

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 3c1b7bb
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/662114310677e400082511b5
😎 Deploy Preview https://deploy-preview-5432--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 3c1b7bb
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/66211431d279fa0008764768
😎 Deploy Preview https://deploy-preview-5432--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jainpawan21 jainpawan21 merged commit 1a462db into next Apr 18, 2024
32 of 34 checks passed
@jainpawan21 jainpawan21 deleted the feature/add-mobile-condition branch April 18, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants