refactor(echo-cli,echo-sdk): relocate to monorepo #5501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for novu-design ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for dev-web-novu ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
scopsy
approved these changes
May 6, 2024
…-packages-to-the-monorepo # Conflicts: # pnpm-lock.yaml
…-packages-to-the-monorepo
…-packages-to-the-monorepo # Conflicts: # pnpm-lock.yaml
…o-the-monorepo' into NV-3670/relocate-echo-packages-to-the-monorepo
|
Boom! |
antonjoel82
pushed a commit
that referenced
this pull request
May 9, 2024
* refactor(echo-cli,echo-sdk): relocate to monorepo * Merge remote-tracking branch 'origin/next' into NV-3670/relocate-echo-packages-to-the-monorepo * fix: lock file conflict * feat: test pipeline * feat: lock file conflict * fix: spell and eslint command * fix: spell disable block * fix: jest export * test: fix sdk tests * feat: remove insecure domain * fix: update c spell comment * fix: update c spell comment * fix: update c spell comment * fix: update c spell comment * feat: create reusable logo --------- Co-authored-by: ainouzgali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
Relocate all Echo Repo packages into the novuhq/novu monorepo repository. No changes to the package.json name entries.
sdk -> packages/sdk
cli -> packages/cli-next (rename to avoid conflict with cli. we will later merge the Echo CLI actions into the original cli)
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer