Update docker-compose.e2e.yml #6721
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AranavMahalpure
requested review from
SokratisVidros and
scopsy
and removed request for
a team
👷 Deploy request for novu-stg-vite-dashboard-poc pending review.Visit the deploys page to approve it
|
|
Hey there and thank you for opening this pull request! 👋 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Your PR title is: Details: No release type found in pull request title "Update docker-compose.e2e.yml". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/ Available types:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why was the change needed?
What Changed: Added environment variables (DEBUG=1, AWS_DEFAULT_REGION, DATA_DIR) for better logging, region consistency, and data persistence. Also improved the health check by adding start_period and timeout.
Why: The changes were needed to enhance the developer experience with more detailed logs, a default AWS region, and persisting LocalStack state across sessions. The health check modifications ensure the container has enough time to start before the checks begin, preventing premature failures.
Related enterprise PR
Special notes for your reviewer
Ensure the Docker container has the right permissions for volume mounting, and verify that the health check passes with the updated configuration.