Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(api): encode workflow and step ids on api response #6725

Open
wants to merge 5 commits into
base: nv-4494-add-slug-parser-in-the-api-requests
Choose a base branch
from
Open

feat(api): encode workflow and step ids on api response #6725

wants to merge 5 commits into from

Conversation

djabarovgeorge
Copy link
Contributor

@djabarovgeorge djabarovgeorge commented Oct 21, 2024 •
edited
Loading

Screenshots

Expand for optional sections

Related enterprise PR

Special notes for your reviewer

@linear Linear
Copy link

linear bot commented Oct 21, 2024

NV-4508 encode workflow and step ids on api response

@netlify Netlify
Copy link

netlify bot commented Oct 21, 2024 •
edited
Loading

✅ Deploy Preview for novu-stg-vite-dashboard-poc ready!

Name Link
🔨 Latest commit f39398f
🔍 Latest deploy log https://app.netlify.com/sites/novu-stg-vite-dashboard-poc/deploys/67167ffd6bc07e00083eebc8
😎 Deploy Preview https://deploy-preview-6725--novu-stg-vite-dashboard-poc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@djabarovgeorge
Merge remote-tracking branch 'origin/nv-4494-add-slug-parser-in-the-a…
f156e8e 
…pi-requests' into nv-4508-encode-workflow-and-step-ids-on-api-response

# Conflicts:
#	apps/api/src/app/step-schemas/e2e/get-step-schema.e2e.ts
#	apps/api/src/app/workflows-v2/mappers/notification-template-mapper.ts
#	apps/api/src/app/workflows-v2/workflow.controller.e2e.ts
#	packages/shared/src/dto/workflows/workflow-commons-fields.ts
@djabarovgeorge
feat(api): update response dto add _id and slug
270d849
@djabarovgeorge djabarovgeorge marked this pull request as ready for review October 21, 2024 16:23
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Oct 21, 2024 •
edited
Loading

Open in Stackblitz

novu

pnpm add https://pkg.pr.new/novuhq/novu@6725

@novu/client

pnpm add https://pkg.pr.new/novuhq/novu/@novu/client@6725

@novu/framework

pnpm add https://pkg.pr.new/novuhq/novu/@novu/framework@6725

@novu/headless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/headless@6725

@novu/js

pnpm add https://pkg.pr.new/novuhq/novu/@novu/js@6725

@novu/nextjs

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nextjs@6725

@novu/nest

pnpm add https://pkg.pr.new/novuhq/novu/@novu/nest@6725

@novu/node

pnpm add https://pkg.pr.new/novuhq/novu/@novu/node@6725

@novu/notification-center

pnpm add https://pkg.pr.new/novuhq/novu/@novu/notification-center@6725

@novu/providers

pnpm add https://pkg.pr.new/novuhq/novu/@novu/providers@6725

@novu/react

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react@6725

@novu/react-native

pnpm add https://pkg.pr.new/novuhq/novu/@novu/react-native@6725

@novu/shared

pnpm add https://pkg.pr.new/novuhq/novu/@novu/shared@6725

@novu/stateless

pnpm add https://pkg.pr.new/novuhq/novu/@novu/stateless@6725

commit: f39398f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@novu/api @novu/shared
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djabarovgeorge