Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Callgraph #185

Merged
merged 58 commits into from
Nov 6, 2024
Merged

Add Callgraph #185

merged 58 commits into from
Nov 6, 2024

Conversation

Esorat
Copy link
Member

@Esorat Esorat commented Oct 17, 2024 •
edited by jubnzv
Loading

Closes #91

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented
  • No test failures were reported when running yarn test-all
  • I did not do unrelated and/or undiscussed refactorings

jubnzv
jubnzv requested changes Oct 18, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, that's a good start. Please add an entry to CHANGELOG, and merge the master branch to your PR in order to simplify the test suite.

src/internals/ir/callGraph.ts Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
callgraph.dot Outdated Show resolved Hide resolved
src/detectors/builtin/sendInLoop.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
@jubnzv jubnzv changed the title fix: Draft Pr for check CallGraph Add Callgraph Oct 18, 2024
@jubnzv jubnzv marked this pull request as draft October 18, 2024 07:37
Esorat added 5 commits October 18, 2024 15:31
@Esorat
fix: make properties public
b2c2cf0
@Esorat
fix: add callGraph to ir CompilationUnit. When building the IR and ca…
26d582f 
…n be access it later: cu.callgraph
@Esorat
fix: add switch case, add forEachExpression for processExpressions, u…
3c07cec 
…pdate constructor and make astStore public

- Refactored `getFunctionName` to use a switch statement for better type safety.
- Introduced `forEachExpression` helper function to handle expression processing recursively and improve code maintainability.
- Updated constructor to remove `astStore` and pass it via the `build()` method, while making `astStore` a public property.
- Updated Ir constructor add CallGraph
- Remove from git .dot output file
@Esorat
fix: add case statement_augmentedassign
b5b93e3
@Esorat
fix: del test/good folder
0b8cb2b
jubnzv
jubnzv requested changes Oct 19, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is much better now. We need to:

  • update the changelog
  • introduce some tests in test/tactIR.spec.ts
  • write a separate tool to dump the callgraph in the supported formats

src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
Esorat added 2 commits October 19, 2024 14:02
@Esorat
fix: add dumpCallgraph
4695954
@Esorat
fix: remake CallGraph add type Aliases.
8e1b8eb 
Add tests.  create Dump callgraph ( in detectors can add this line (    DumpCallGraph.run(cu); )
jubnzv
jubnzv requested changes Oct 20, 2024
View reviewed changes
src/internals/ir/builders/astStore.ts Outdated Show resolved Hide resolved
src/detectors/detector.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/tools/dumpCallgraph.ts Outdated Show resolved Hide resolved
@Esorat Esorat marked this pull request as ready for review October 20, 2024 07:33
jubnzv
jubnzv requested changes Nov 4, 2024
View reviewed changes
test/all/syntax.expected.callgraph.dot Outdated Show resolved Hide resolved
src/tools/dumpCallgraph.ts Outdated Show resolved Hide resolved
src/tools/dumpCallgraph.ts Outdated Show resolved Hide resolved
src/tools/dumpCallgraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
jubnzv
jubnzv reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Let's fix minor issues before merging it.

src/internals/ir/builders/ir.ts Outdated Show resolved Hide resolved
src/internals/ir/builders/ir.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Show resolved Hide resolved
src/internals/ir/callGraph.ts Show resolved Hide resolved
@jubnzv
Copy link
Member

jubnzv commented Nov 6, 2024

We also need an entry in CHANGELOG.md

jubnzv
jubnzv reviewed Nov 6, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
src/internals/ir/callGraph.ts Outdated Show resolved Hide resolved
jubnzv and others added 14 commits November 6, 2024 10:28
@jubnzv
Update CHANGELOG.md
818b826
@jubnzv
Update src/internals/ir/callGraph.ts
0f59933
@jubnzv
Update src/internals/ir/callGraph.ts
76b8753
@Esorat @jubnzv
Update src/internals/ir/callGraph.ts
5932983 
Co-authored-by: Georgiy Komarov <[email protected]>
@Esorat @jubnzv
Update src/internals/ir/callGraph.ts
53ddeb2 
Co-authored-by: Georgiy Komarov <[email protected]>
@Esorat @jubnzv
Update src/internals/ir/callGraph.ts
89294c1 
Co-authored-by: Georgiy Komarov <[email protected]>
@Esorat @jubnzv
Update src/internals/ir/callGraph.ts
8fe7500 
Co-authored-by: Georgiy Komarov <[email protected]>
@Esorat @jubnzv
Update src/internals/ir/callGraph.ts
33cae65 
Co-authored-by: Georgiy Komarov <[email protected]>
@Esorat @jubnzv
Update src/internals/ir/callGraph.ts
94da560 
Co-authored-by: Georgiy Komarov <[email protected]>
@Esorat @jubnzv
Update src/internals/ir/callGraph.ts
3145037 
Co-authored-by: Georgiy Komarov <[email protected]>
@Esorat
Chore: yarn fix-all
08b21c0
@jubnzv
Update src/internals/ir/callGraph.ts
d780e4a
@jubnzv
Update src/internals/ir/callGraph.ts
e65a098
@jubnzv
Update src/internals/ir/callGraph.ts
95359b8
jubnzv
jubnzv approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@jubnzv jubnzv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jubnzv jubnzv merged commit a26986c into nowarp:master Nov 6, 2024
1 check passed
@nowarp nowarp deleted a comment Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jubnzv jubnzv jubnzv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Callgraph
2 participants
@Esorat @jubnzv