Before after scaling-2L #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated files after running count_scaling
rnowling
requested changes
Jun 8, 2021
| @@ -32,10 +43,10 @@ merge_batch_size: 512 | |||
| min_doc_freq: 2 | |||
|
|
|||
| # feature extraction | |||
| n_features: 30 | |||
| n_features: 16 | |||
| n_rand_dim: 3000 | |||
| @@ -32,10 +43,10 @@ merge_batch_size: 512 | |||
| min_doc_freq: 2 | |||
|
|
|||
| # feature extraction | |||
| n_features: 30 | |||
| n_features: 16 | |||
| n_rand_dim: 3000 | |||
| @@ -32,10 +43,10 @@ merge_batch_size: 512 | |||
| min_doc_freq: 2 | |||
|
|
|||
| # feature extraction | |||
| n_features: 30 | |||
| n_features: 16 | |||
| import numpy as np | ||
|
|
||
|
|
||
| def load_rand_proj(flname): |
| def load_rand_proj(flname): | ||
| return load(flname) | ||
|
|
||
| def load_bloomfilter(flname): |
| @@ -0,0 +1,116 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Why is this file in here twice? Is this version ever used or just the one under scripts?
There was a problem hiding this comment.
just the one under scripts.
| @@ -7,6 +7,9 @@ | |||
| from pybloom import BloomFilter | |||
| import scipy.sparse as sp | |||
| from sklearn.feature_extraction import FeatureHasher | |||
| from sklearn.preprocessing import Binarizer | |||
| import numpy as np | |||
|
|
|||
|
|
|||
| def load_rand_proj(flname): | |||
| @@ -7,6 +7,9 @@ | |||
| from pybloom import BloomFilter | |||
| args = parse_args() | ||
|
|
||
| @@ -57,7 +57,8 @@ def parse_args(): | |||
| matrices.append(matrix) | |||
| labels.append(group_name) | |||
|
|
|||
| feature_matrix = sp.vstack(matrices).toarray() | |||
| #feature_matrix = sp.vstack(matrices).toarray() | |||
There was a problem hiding this comment.
Remove this line since you commented it out
|
Then you shouldn't commit the file if it isn't used.
…On Tue, Jun 8, 2021 at 10:12 PM Daniel Leskiewicz ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In feature_extractor.py
<#15 (comment)>:
> @@ -0,0 +1,116 @@
+#!/usr/bin/env python
just the one under scripts.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#15 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIQGCDQSUXPRPYY52FGYBTTR3L2ZANCNFSM45MT5MXA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the updated files pulled from the remote machine that were used to create plots on doing the count scaling on the 2L chromosome arm.