Refactor test using LoadScene attribute #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
nowsprinting
commented
Oct 28, 2023
•
nowsprinting
commented
- Upgrade test-helper package to v0.3.0
- Upgrade test-helper.monkey to v0.5.0
- Using test-helper.random package v0.2.0
- Refactor tests using LoadSceneAttribute
- Refactor tests in SceneExample using LoadSceneAttribute
- Add note about refactor SceneExample using LoadSceneAttribute
- Add CreateSceneAttribute example
- Add EditorSceneManager.LoadSceneAsyncInPlayMode example (revert from TestSceneLoader)
IRandom was removed in test-helper v0.3.0
『Unity Test Framework完全攻略ガイド』10.2.2 および 10.3 で紹介している処理を、 Test Helper パッケージ（com.nowsprinting.test-helper）に含まれる LoadScene 属性に置き換え。
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Code Metrics Report
Details | | master (4916c12) | #15 (ebb23ca) | +/- |
|---------------------|------------------|---------------|--------|
+ | Coverage | 37.4% | 38.3% | +0.9% |
| Files | 31 | 30 | -1 |
| Lines | 519 | 507 | -12 |
| Covered | 194 | 194 | 0 |
+ | Code to Test Ratio | 1:42.5 | 1:44.2 | +1.7 |
| Code | 1360 | 1334 | -26 |
+ | Test | 57784 | 58897 | +1113 |
+ | Test Execution Time | 6m22s | 3m43s | -2m39s |Code coverage of files in pull request scope (0.0% → 0.0%)
Reported by octocov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.