-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macie baseline #210
base: main
Are you sure you want to change the base?
Macie baseline #210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the proposal, enabling Macie is definitely a good move 🎉
macie_baselines.tf_
tries to enable Macie in each region while in main.tf
there is a module declaration only for the main region, so we should pick one.
Given that Macie is a regional service as described in the official FAQ, I guess macie_baselines.tf_
way is preferable?
Oops, good catch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willfarrell Thank you for the quick update!
I tested with my account, and it seems Macie only gathers information from S3 buckets which reside in the correspondent region. So I guess we need to enable Macie region by region to monitor all S3 buckets as described in CIS benchmark v1.4.0 2.1.4. Feel free to let me know if I'm missing something, thanks!
I'll do some more testing, I'm still pretty new to Macie myself. I'm setup with a management account with multiple sub-accounts. When I was building it and trying to enable per region it was throwing error, I'll do some more digging into the docs. |
Closes: #208