Applied direct reply-to logic - next steps and feedback #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the callback_queue from a user-created one to
amq.rabbitmq.reply-to
. This has resolved the issues described in the README, but I fail to understand why the previous approach did not work.Also, the code now always uses the direct reply-to logic, is this the best choice?
I would also like some feedback on the things to consider when expanding this code base to a client and server that can recover from connection issues and whether I should start compiling an example of a non-blocking connection.