Provide a better exception message for invalid data source config. (#…

…2796)
npgsql · Jun 23, 2023 · f3e21dc · f3e21dc
1 parent 5784b52
commit f3e21dc
Showing 1 changed file with 19 additions and 5 deletions.
diff --git a/src/EFCore.PG/Infrastructure/Internal/NpgsqlOptionsExtension.cs b/src/EFCore.PG/Infrastructure/Internal/NpgsqlOptionsExtension.cs
@@ -2,6 +2,7 @@
 using System.Globalization;
 using System.Net.Security;
 using System.Text;
+using Npgsql.EntityFrameworkCore.PostgreSQL.Internal;
 
 namespace Npgsql.EntityFrameworkCore.PostgreSQL.Infrastructure.Internal;
 
@@ -242,12 +243,25 @@ public override void Validate(IDbContextOptions options)
         var dataSource = DataSource
             ?? options.FindExtension<CoreOptionsExtension>()?.ApplicationServiceProvider?.GetService<NpgsqlDataSource>();
 
-        if (dataSource is not null
-            && (ProvideClientCertificatesCallback is not null
-                || RemoteCertificateValidationCallback is not null
-                || ProvidePasswordCallback is not null))
+        if (dataSource is not null)
         {
-            throw new InvalidOperationException();
+            if (ProvideClientCertificatesCallback is not null)
+            {
+                throw new InvalidOperationException(
+                    "When passing an NpgsqlDataSource to UseNpgsql(), call 'ProvideClientCertificatesCallback' on NpgsqlDataSourceBuilder rather than in UseNpgsql().");
+            }
+
+            if (RemoteCertificateValidationCallback is not null)
+            {
+                throw new InvalidOperationException(
+                    "When passing an NpgsqlDataSource to UseNpgsql(), call 'RemoteCertificateValidationCallback' on NpgsqlDataSourceBuilder rather than in UseNpgsql().");
+            }
+
+            if (ProvidePasswordCallback is not null)
+            {
+                throw new InvalidOperationException(
+                    "When passing an NpgsqlDataSource to UseNpgsql(), 'ProviderPasswordCallback' cannot be used in UseNpgsql(). See https://www.npgsql.org/doc/security.html for configuring passwords and token rotation on NpgsqlDataSourceBuilder.");
+            }
         }
 
         if (UseRedshift && _postgresVersion is not null)