Support for table partitioning #1035 #1789
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty type model (npgsql#1035) * Added Extension methods to builders to allow Partitioning * Added SQL generation for Partitioning Fixes npgsql#1035
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to support Npgsql Table Partitioning as part of the EF Core entity type model (#1035)
Fixes #1035
@roji
Hi, I've taken a stab at #1035.
It's my first time working with EF's annotation and I feel like there is a gap in my knowledge of them that prevents me from making this development work. I've defined a type "TablePartitioning" under Metadata which I wanted to represent the configuration used to Partition the EntityType's table, but after some testing it looks like I can't do this as annotations would require literals for their values.
What alternative would you suggest to make this work? There is the possibility of storing the TablePartitioningType and the string[] of properties as two different annotations, but maybe there is a better?
Also, to my knowledge, there is no way of altering the table partitioning once the table has been created. I handled this by throwing an exception as part of the NpgsqlMigrationsSqlGenerator. Is this the right approach?
Thank you!