Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncing Connection and ConnectionString fix the bug that AdminDatabase Setting is invalid when DataSource is setted. #3127

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Syncing Connection and ConnectionString fix the bug that AdminDatabase Setting is invalid when DataSource is setted. #3127

wants to merge 1 commit into from

Commits on Mar 7, 2024

  1. sync Connection and ConnectionString 

    When both Connection and ConnectionString are not null, Connection's ConnectionString is different to ConnectionString, the ConnectionString will be used instead of the Connection's ConnectionString.

It will cause a bug, for example, I need to create database through following code:

```csharp
DbContext.Database.Migrate()
```
if DatabaseSource is Setted:

```csharp
extension.WithDataSource(dataSource);
```
 then we set AdminDatabase:

```csharp
extension.WithAdminDatabase("postgres");
```
it wont work.
    @tianvan
    tianvan authored Mar 7, 2024
    Configuration menu
    Copy the full SHA
    ac9545f View commit details
    Browse the repository at this point in the history