This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Update vqfx (light) image #251
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
container-vqfximage has many improvements over the existing vqfx image, but isn't quite ready for primetime.The vqfx image that is currently in use by the vast majority of lessons has not been added to the automatic build process, primarily because we've been using snapshots, and that adds some complexity when trying to automate an image build. While this is more or less figured out, this PR merely gets the image to be automatically built in the same way the
container-vqfxexists now, but with this image's existing, simpler, launch script.We'll leave snapshots out of it for now - with the performance enhancements going into selfmedicate in the near future, and the production site moving to baremetal, it's likely that we can get away with not using snapshots, which - if true - will reduce a lot of complexity on the lesson builder's side, and we won't be restricted to the three images
antidotelabs/vqfx:snap1,snap2,snap3.TODO(mierdin)