Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support home dir tilda sign #81

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

support home dir tilda sign #81

wants to merge 7 commits into from

Conversation

rarmatei
Copy link
Contributor

@rarmatei rarmatei commented Dec 19, 2024 •
edited
Loading

Allows this to work, as Node itself doesn't know to expand the tilda sign:

      - name: Restore Node Modules Cache
        uses: 'nrwl/nx-cloud-workflows/v4/workflow-steps/cache/main.yaml'
        inputs:
          key: 'package-lock.json|yarn.lock|pnpm-lock.yaml|"15"'
          paths: ~/.npm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Dec 19, 2024 •
edited
Loading

View your CI Pipeline Execution ↗ for commit b9bc541.

Command Status Duration Result
nx affected -t test ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-19 17:58:07 UTC

rarmatei
rarmatei commented Dec 19, 2024
View reviewed changes
workflow-steps/cache/hashing-utils.ts
const directories = Array.from(
new Set(
inputPaths
.split('\n')
.filter((p) => p)
.map((p) => p.replace(/^~/, '..'))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this now considers changes to the paths as well into the cache - if you change the paths, it should invalidate the cache as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rarmatei