feat(core): add support for bun pack #27820
Open
+23
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 61f8a22. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
Jordan-Hall
commented
Sep 8, 2024
| @@ -26,6 +26,7 @@ export interface PackageManagerCommands { | |||
| exec: string; | |||
| dlx: string; | |||
| list: string; | |||
| pack: string; | |||
There was a problem hiding this comment.
This has been added but i'm not sure if a better name can be used. bun uses bun install at top level and bunx but rest of its package manager commands is at bun pm level
Jordan-Hall
force-pushed
the
feat-support-bun-pack
branch
from
2e28929
to
7f98cd3
Compare
Jordan-Hall
force-pushed
the
feat-support-bun-pack
branch
from
7f98cd3
to
61f8a22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Before release last night/today of bun 1.1.27 bun pm pack didn't exists so we fell upon npm pack.
Expected Behavior
If bun 1.1.27 or greater we use bun pm pack otherwise we revert to npm pack
https://x.com/bunjavascript/status/1832386689182122092
cc: @jaysoo