Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite/test): partial support for vitest@2 #27831

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rluvaton
Copy link
Contributor

@rluvaton rluvaton commented Sep 9, 2024

When having no tests the process will hang, this is because onFinished event is never emitted when no test exists and before version 2, the process was terminated, but not it was not

this is the vitest PR that changed it:
vitest-dev/vitest#5926

When having no tests the process will hang, this is because `onFinished` event is never emitted when no test exists and before version 2, the process was terminated, but not it was not

this is the vitest PR that changed it:
vitest-dev/vitest#5926
@rluvaton rluvaton requested a review from a team as a code owner September 9, 2024 14:16
@rluvaton rluvaton requested a review from jaysoo September 9, 2024 14:16
Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 9, 2024 2:19pm

Copy link

nx-cloud bot commented Sep 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 40bcc72. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx-cloud record -- nx format:check --base=e768de6296f32d8c4c85eb7a70af0aed718bac35 --head=40bcc72e74719b416146e97f5f8200679a7a4603
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant