Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(testing): update test generators to exclude test files from the runtime tsconfig file #27991

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Sep 19, 2024
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 19, 2024 11:11am

@leosvelperez leosvelperez force-pushed the testing/rework-spec-files-config-generation branch from c1af6b6 to ddc7362 Compare September 19, 2024 11:03
@leosvelperez leosvelperez changed the title cleanup(testing): wip feat(testing): update test generators to exclude test files from the runtime tsconfig file Sep 19, 2024
@leosvelperez leosvelperez marked this pull request as ready for review September 19, 2024 13:37
@leosvelperez leosvelperez requested review from a team as code owners September 19, 2024 13:37
Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's wait for 19.8 to release, and this will be in v20.

@jaysoo jaysoo merged commit d454f25 into master Sep 23, 2024
6 checks passed
@jaysoo jaysoo deleted the testing/rework-spec-files-config-generation branch September 23, 2024 13:25
Copy link

github-actions bot commented Oct 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants