Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(repo): ensure nightly tests pass majority of the time #29237

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Dec 6, 2024

This PR is address some failures in our nightly tests.

  • Tests were timing out after 60/90 minutes, so increased to 120 minutes. This problem was made worse when we combined tests from several projects into a single atomized project. e.g. e2e-react used to be multiple projects that all took under 60 minutes.
  • npm view command changed the error output so some versions show npm error code E404 instead of npm ERR! code E404. This is now fixed to account for both.
  • NX_VERBOSE_LOGGING is causing output to contain things that were asserted against, or if the output is piped to a JSON file, that JSON file is invalid since it contains additional logging. For these tests, set NX_VERBOSE_LOGGING: 'false' when using runCLI.
  • Disable one Next.js e2e test for LESS CSS (only for yarn) as it is failing only on Yarn with Node 20. LESS isn't supported by default by Next.js so it's not high priority.
  • Disable e2e-lerna-smoke-tests for yarn as there are newline differences in snapshots. Needs to be investigated.
  • Disable e2e-plugin for Linux + Yarn + Node 20 since it is failing due to yarn create-plugin error https://staging.nx.app/runs/3cIYidmpyy. Needs to be investigated.
  • run.test.ts for e2e-nx is failing on avj version mismatch. Use the Vite bundler for now as Webpack is covered in other e2e tests.

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 0:48am

Copy link

nx-cloud bot commented Dec 6, 2024

@jaysoo jaysoo force-pushed the chore/make_nightly_green branch 6 times, most recently from dde9e37 to 26ff7bd Compare December 10, 2024 00:44
@jaysoo jaysoo force-pushed the chore/make_nightly_green branch from 26ff7bd to c2403d5 Compare December 10, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant