-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add support for React 19 for new Workspaces #29286
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
View your CI Pipeline Execution ↗ for commit 3a49476.
☁️ Nx Cloud last updated this comment at |
@Coly010 how this affects Next apps?... |
Blocked until Unit Testing solution is ready |
39a45a3
to
a531760
Compare
I see that this pr introduce a create graph async during a generator, this is already causing issues regarding eslint (see #27849), can we envision a generator parameter to explicitly say the version of react to expect? Otherwise, every generator that are built on top of this will have their test and run go way slower due to creating a fresh graph |
a531760
to
a015576
Compare
a015576
to
5164a7b
Compare
a3d9891
to
2eaf48b
Compare
@Coly010 can you add vitest support to next app generator too? 🙏🏻 |
dc47dfd
to
ee443c6
Compare
🐳 We have a release for that!This PR has a release associated with it. You can try it out using this command: npx [email protected] my-workspace Or just copy this version and use it in your own command: 0.0.0-pr-29286-735af1e
To request a new release for this pull request, mention someone from the Nx team or the |
735af1e
to
8676e85
Compare
8676e85
to
c29c2fb
Compare
c29c2fb
to
e8a8e87
Compare
e8a8e87
to
c05425c
Compare
c05425c
to
d01acef
Compare
9abc978
to
3a49476
Compare
@Coly010 you may also want to remove |
Current Behavior
We currently have no support for React 19, generating only React 18 applications.
Expected Behavior
Add utils to determine what version of React is installed in the workspace.
If React 18 is the main version of react installed, continue to generate React 18 projects.
If React 19 is the main version of react installed, generate React 19 projects.
If no React version is installed or can be determined, generate React 19 projects.