fix(core): show better errors #29525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
JamesHenry
requested changes
Jan 6, 2025
AgentEnder
force-pushed
the
fix/show-better-errors
branch
from
326d9b0 to
65466a2
Compare
|
View your CI Pipeline Execution ↗ for commit df82ea9.
☁️ Nx Cloud last updated this comment at |
JamesHenry
approved these changes
Jan 8, 2025
AgentEnder
force-pushed
the
fix/show-better-errors
branch
from
65466a2 to
9ed7de2
Compare
FrozenPandaz
requested changes
Jan 9, 2025
There was a problem hiding this comment.
I malformed the project.json of cart and these are the logs that I get:
Non Verbose:
~/p/nx-examples (master|✚4) [1]$ nx show projects
NX Failed to process project graph, there may be an issue with one of your Nx plugins. If the cause is not obvious from the error message, running "nx reset" may fix it. Please report the issue if you keep seeing it. See errors below.
- apps/cart/project.json: CommaExpected in /home/jason/projects/nx-examples/apps/cart/project.json at 7:3
5 | "projectType": "application",
6 | "generators": {}
> 7 | "targets": {
| ^^^^^^^^^
8 | "build": {
9 | "executor": "@nx/webpack:webpack",
10 | "options": {
- apps/cart/jest.config.ts: CommaExpected in apps/cart/project.json at 7:3
5 | "projectType": "application",
6 | "generators": {}
> 7 | "targets": {
| ^^^^^^^^^
8 | "build": {
9 | "executor": "@nx/webpack:webpack",
10 | "options": {
The projects in the following directories have no name provided:
- apps/cartThese logs are better than what it was before but they're still missing some information which would be helpful.
I think the plugin name or index would allow people to identify which plugin was causing the error... I almost feel like there's a line missing before the JSON error 🤔
| readonly #partialProjectGraph: ProjectGraph; | ||
| readonly #partialSourceMaps: ConfigurationSourceMaps; | ||
|
|
||
| constructor( | ||
| errors: Array< | ||
| private readonly errors: Array< |
There was a problem hiding this comment.
This allows errors get serialized right?
AgentEnder
commented
Jan 9, 2025
Comment on lines
240
to
242
| error.message = `${ | ||
| error.errors.length > 1 ? `${error.errors.length} errors` : 'An error' | ||
| } occurred while processing files for the ${pluginName} plugin.`; |
AgentEnder
force-pushed
the
fix/show-better-errors
branch
2 times, most recently
from
cdca42d to
73db4d8
Compare
AgentEnder
force-pushed
the
fix/show-better-errors
branch
from
73db4d8 to
df82ea9
Compare
FrozenPandaz
approved these changes
Jan 14, 2025
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
## Current Behavior Sub-errors are hidden when any project graph error is encountered. This is detrimental, as things like "missing comma in JSON" get hidden and make people think that Nx is broken, when in fact their config files are invalid. ## Expected Behavior Sub errors are shown regardless of verbose logging (but including their stack trace if verbose logging is enabled) ### Without Verbose  ### With Verbose  ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit c060b3a)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Sub-errors are hidden when any project graph error is encountered. This is detrimental, as things like "missing comma in JSON" get hidden and make people think that Nx is broken, when in fact their config files are invalid.
Expected Behavior
Sub errors are shown regardless of verbose logging (but including their stack trace if verbose logging is enabled)
Without Verbose
With Verbose
Related Issue(s)
Fixes #