-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): allow tasks to run with a substring of project name #29552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
View your CI Pipeline Execution ↗ for commit c847c4d.
☁️ Nx Cloud last updated this comment at |
jaysoo
force-pushed
the
feat/run-project-with-substring
branch
4 times, most recently
from
January 8, 2025 20:42
c2d9663
to
c5a0e0f
Compare
AgentEnder
approved these changes
Jan 8, 2025
FrozenPandaz
requested changes
Jan 8, 2025
jaysoo
force-pushed
the
feat/run-project-with-substring
branch
2 times, most recently
from
January 9, 2025 13:44
a38f510
to
90c8349
Compare
FrozenPandaz
requested changes
Jan 9, 2025
jaysoo
force-pushed
the
feat/run-project-with-substring
branch
from
January 9, 2025 16:49
90c8349
to
06374bd
Compare
jaysoo
force-pushed
the
feat/run-project-with-substring
branch
from
January 9, 2025 16:53
06374bd
to
c847c4d
Compare
FrozenPandaz
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When projects use only
package.json
and notproject.json
, we need to set the simple name in thenx
property ofpackage.json
. This isn't ideal because it's yet another Nx-specific thing that needs to be configured when our goal is to reduce boilerplate.This PR allows users to pass a substring that matches exactly one project when running a task.
For example, if
@acme/foo
is the name inpackage.json
, then runningnx build foo
will match it.If more than one projects match, then an error is thrown showing all the matched projects, and the user has to be more specific or type in the fully qualified name.
Current Behavior
Users need to pass exact matches for project names when running tasks.
Expected Behavior
User can pass a substring matching the project name.
Related Issue(s)
Fixes #