Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gradle): check if java is installed #29572

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(gradle): check if java is installed #29572

wants to merge 1 commit into from

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Jan 9, 2025 •
edited
Loading

Current Behavior

Expected Behavior

throw an error when ./gradlew wrapper or java -version failed to run:
Screenshot 2025-01-09 at 5 33 38 PM
Screenshot 2025-01-09 at 5 32 20 PM

Related Issue(s)

Fixes #

@xiongemi xiongemi requested a review from FrozenPandaz as a code owner January 9, 2025 17:16
@vercel Vercel
Copy link

vercel bot commented Jan 9, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 1:19am

@xiongemi xiongemi force-pushed the feature/nxc-1240-handle-when-java-or-gradle-is-not-installed branch from 2a6ddc0 to c93a107 Compare January 9, 2025 18:53
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 9, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit ab0106a.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 12m 51s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 8s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=cbfc6... ✅ Succeeded 18s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 17s View ↗
nx documentation --no-dte ✅ Succeeded 40s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-10 01:36:20 UTC

@xiongemi xiongemi force-pushed the feature/nxc-1240-handle-when-java-or-gradle-is-not-installed branch from c93a107 to 63c7ccf Compare January 9, 2025 18:57
@xiongemi xiongemi force-pushed the feature/nxc-1240-handle-when-java-or-gradle-is-not-installed branch 2 times, most recently from 7cfc874 to 01a42d2 Compare January 9, 2025 22:23
@xiongemi xiongemi force-pushed the feature/nxc-1240-handle-when-java-or-gradle-is-not-installed branch from 01a42d2 to ab0106a Compare January 10, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrozenPandaz FrozenPandaz FrozenPandaz requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiongemi @FrozenPandaz