fix(js): update detection of ts solution setup #29576
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we simplified
tsconfig.base.json
'scompilerOptions
to not include values that match defaults (as per Jake's feedback), the logic to detect TS solution setup should check thatdeclaration
is explicitly set tofalse
, rather than that it is falsy.Clean up PR: #29550
Current Behavior
We're not detecting TS solution setup correctly
Expected Behavior
Detection works
Related Issue(s)
Fixes #