Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): update detection of ts solution setup #29576

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 9, 2025

Since we simplified tsconfig.base.json's compilerOptions to not include values that match defaults (as per Jake's feedback), the logic to detect TS solution setup should check that declaration is explicitly set to false, rather than that it is falsy.

Clean up PR: #29550

Current Behavior

We're not detecting TS solution setup correctly

Expected Behavior

Detection works

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner January 9, 2025 19:58
@jaysoo jaysoo requested a review from leosvelperez January 9, 2025 19:58
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 8:44pm

Copy link

nx-cloud bot commented Jan 9, 2025

View your CI Pipeline Execution ↗ for commit 2431f68.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 3m 17s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 22s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=a77e3... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation --no-dte ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-09 20:51:32 UTC

@jaysoo jaysoo enabled auto-merge (squash) January 9, 2025 20:14
@jaysoo jaysoo force-pushed the fix/ts-solution-detection branch from ede7b21 to 2431f68 Compare January 9, 2025 20:42
@jaysoo jaysoo merged commit cbfc6fe into master Jan 9, 2025
6 checks passed
@jaysoo jaysoo deleted the fix/ts-solution-detection branch January 9, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants