fix(release): ensure git push option is always applied #29596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
thdk
changed the title
|
View your CI Pipeline Execution ↗ for commit d86822c.
☁️ Nx Cloud last updated this comment at |
JamesHenry
changed the title
|
Note, I reworded your PR pre-merge to read more like a resolution rather than an issue description |
FrozenPandaz
pushed a commit
that referenced
this pull request
Jan 15, 2025
(cherry picked from commit bde8a21)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Running
nx release --git-pushdoesn't push changes to the remote.Running
nx release --git-push --projects my-projectdoes push changes to the remote.Expected Behavior
nx releasecommands should always push commits and tags whenever git push (either in nx.json or from command arguments) is set.Related Issue(s)
Fixes #29595