Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cesiumBaseUrl option #55

Merged
merged 2 commits into from
Aug 6, 2024
Merged

add cesiumBaseUrl option #55

merged 2 commits into from
Aug 6, 2024

Conversation

rot1024
Copy link
Contributor

@rot1024 rot1024 commented Aug 5, 2024

Allows you to change the name of the directory to which Cesium is copied.

This is important for the delivery of Cesium-related files to ensure that Cache-Control is properly configured and that the CDN is leveraged for high performance delivery. A hash or version number can be appended to the directory name to avoid Cache-Control problems when deploying a new version.

This feature has been tested using a demo (see cesium2, it's a different path from default):
image

@nshen
Copy link
Owner

nshen commented Aug 6, 2024

Thank you very much @rot1024 . I haven't touched this project in a long time. I'd love to merge it but do you know what these errors in the CI mean?

@rot1024
Copy link
Contributor Author

rot1024 commented Aug 6, 2024

Now Node.js v16 is already EOL and the latest version of Cesium does not support node v16. It causes that error. To fix CI, it should be done in a separate PR I think.

@nshen nshen merged commit dddac6c into nshen:main Aug 6, 2024
@nshen
Copy link
Owner

nshen commented Aug 6, 2024

Thanks @rot1024 , it seems you have been stick on reearth for very long timet. Are you working on this project full-time? Do you have any income from it?

@rot1024
Copy link
Contributor Author

rot1024 commented Aug 7, 2024

Yes I am working on Re:Earth (Eukarya Inc.) in full time. We love vite-plugin-cesium and each Re:Earth apps use it. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants