Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intial draft for maintainer doc #608

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

Sherwin-14
Copy link
Contributor

@Sherwin-14 Sherwin-14 commented Jun 23, 2024

I've made this doc as per my understanding. Open to discussing what more/less could be done here.


📚 Documentation preview 📚: https://earthaccess--608.org.readthedocs.build/en/608/

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks so much for your work. A couple nitpicky suggestions :)

docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
docs/maintainers-guide.md Outdated Show resolved Hide resolved
@mfisher87
Copy link
Member

pre-commit.ci autofix

Copy link
Member

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one last thing: There's currently no link to get to this page. What do you think of including it in the "Work with us" part of the side nav (mkdocs.yml)?

I was thinking we should also move the file into the doc/contributing directory. Do you agree?

docs/maintainers-guide.md Outdated Show resolved Hide resolved
@mfisher87
Copy link
Member

@Sherwin-14 LGTM! Let me know if you're ready to merge or if you'd like some time to rebase beforehand.

@Sherwin-14
Copy link
Contributor Author

@mfisher87 I am ready to merge, you can decide as per your convenience :)

@mfisher87 mfisher87 merged commit 860be56 into nsidc:main Jun 25, 2024
11 checks passed
@mfisher87
Copy link
Member

Thank you for your contribution :)

@mfisher87 mfisher87 linked an issue Jul 9, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We don't have maintainer documentation
2 participants