Add address and swap endianness to vm opcode dump for hashes #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatiana-nspcc
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov Report
@@ Coverage Diff @@
## master #3115 +/- ##
==========================================
+ Coverage 84.84% 84.90% +0.06%
==========================================
Files 330 330
Lines 44343 44349 +6
==========================================
+ Hits 37621 37656 +35
+ Misses 5210 5178 -32
- Partials 1512 1515 +3
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
roman-khimov
approved these changes
Sep 4, 2023
pkg/vm/vm.go
Outdated
| // if the parameter is a 20-byte value. | ||
| u, err := util.Uint160DecodeBytesBE(parameter) | ||
| if err == nil { | ||
| desc = fmt.Sprintf("%x (Address:%q, Swap Endianness:%q)", parameter, address.Uint160ToString(u), "0x"+hex.EncodeToString(slice.CopyReverse(parameter))) |
There was a problem hiding this comment.
I'd avoid "address:" and "swap endianness:", the first one is obvious, the second is also not that hard to understand (Neo uses "0x..." notation for stringified reversed hashes all over the place).
If the parameter in the opcode dump is a 20-byte value, the converted values, such as the address and the swapped endianness, have been added. Signed-off-by: Tatiana Nesterenko <[email protected]>
tatiana-nspcc
force-pushed
the
3030-opcode-dumps
branch
from
509eeae
to
259cbc3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Having difficulties manually converting hashes in opcode dumps.
The problem is described in #3030
Solution
If the parameter in the opcode dump is a 20-byte value, then add converted values, such as the address and the swapped endianness.
Close #3030