Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linter for every module #3605

Merged
merged 7 commits into from
Oct 11, 2024
Merged

Enable linter for every module #3605

merged 7 commits into from
Oct 11, 2024

Conversation

AnnaShaleva
Copy link
Member

Problem

9f93123

Solution

Make it green.

@AnnaShaleva
Copy link
Member Author

Error: ./nns_test.go:161:6: i declared and not used

NNS linter is still failing, but it's fixed in #3604.

Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile should be updated as well then.

scripts/go.mod Outdated Show resolved Hide resolved
examples/zkp/xor_compat/verify.go Outdated Show resolved Hide resolved
@AnnaShaleva
Copy link
Member Author

Makefile should be updated as well then.

Not fixed yet, I need to read about proper configuration.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.22%. Comparing base (8ed3ab8) to head (8bdb8af).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3605      +/-   ##
==========================================
- Coverage   85.25%   85.22%   -0.04%     
==========================================
  Files         333      333              
  Lines       39009    39009              
==========================================
- Hits        33258    33244      -14     
- Misses       4180     4199      +19     
+ Partials     1571     1566       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Anna Shaleva <[email protected]>
Avoid situations like 9f93123.

Signed-off-by: Anna Shaleva <[email protected]>
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva AnnaShaleva force-pushed the fix-linter branch 2 times, most recently from d9144dc to 96b5f80 Compare October 11, 2024 09:28
Copy link
Member

@roman-khimov roman-khimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

workflows add linter for scripts in the commit message.

Signed-off-by: Anna Shaleva <[email protected]>
Enable linter for examples, scripts and interop packages.

Signed-off-by: Anna Shaleva <[email protected]>
@AnnaShaleva
Copy link
Member Author

Let's see if re-run helps with CodeQL.

@AnnaShaleva AnnaShaleva merged commit a924253 into master Oct 11, 2024
34 of 35 checks passed
@AnnaShaleva AnnaShaleva deleted the fix-linter branch October 11, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants