Support new operators in eACL rules #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthulhu-rider
requested review from
carpawell and
roman-khimov
as code owners
roman-khimov
previously approved these changes
Feb 2, 2024
cthulhu-rider
force-pushed
the
feature/256-acl-missing-attr
branch
from
3d62eda
to
97781ce
Compare
Previously, protocol did not clearly support access rules based on attribute absence. Using `STRING_EQUAL` op with empty value was an insufficiently clear notation of a missing attribute since it could cause a collision with attributes with an empty value (there are no such things now, but they may be possible in the future). `MatchType` enumeration is extended with `NOT_PRESENT` value. Being set in the `EACLRecord.Filter`, this operator will limit access rule to the objects without. The op is prohibited for system attributes so as not to create deliberately false (for known attributes) or undefined behavior (for unsupported ones). Closes #256. Signed-off-by: Leonard Lyubich <[email protected]>
Previously, protocol did not support numeric comparisons in access rules except `==` and `!=`. This may be needed for system attributes such as payload size or creation epoch, and for user ones if required by the client application. New values of `MatchType` enumeration are added: `>`, `>=`, `<`, `<=`. Being set in the `EACLRecord.Filter`, these operators will allow user to apply access rules with any decimal attributes. While only base-10 numbers are allowed, additional bases may be supported in the future without new enumerations. Closes #255. Refs #265. Signed-off-by: Leonard Lyubich <[email protected]>
cthulhu-rider
force-pushed
the
feature/256-acl-missing-attr
branch
from
97781ce
to
541cd3c
Compare
|
fixed markdown a bit |
carpawell
approved these changes
Feb 5, 2024
roman-khimov
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.