Fix/complex objects relations #2810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will simplify inhuming children objects without network communications. Signed-off-by: Pavel Karpy <[email protected]>
Can be used for internal root objects extension (when inhuming the root object should become inhuming all the children operation). Also make all the setters check nil pointers to be in sync. Signed-off-by: Pavel Karpy <[email protected]>
We are moving towards not using child objects in the helpers objects (Tombstones and Storage groups) so engine should learn to live with it first. Signed-off-by: Pavel Karpy <[email protected]>
Now we are always checking if objects exists. Signed-off-by: Pavel Karpy <[email protected]>
This part of the code does not mark anything. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/complex-objects-relations
branch
2 times, most recently
from
a26704e
to
3ace6a8
Compare
Do not allow putting tombstones that contain any child object of a complete (finished, fully uploaded) user's big object. Only unfinished big objects can be partially put to a tombstone to perform garbage collecting. From now, client should attach only root object IDs to the tombstones, all the removal magic will be applied later internally. Closes #2093. Signed-off-by: Pavel Karpy <[email protected]>
It is prohibited and validated now. Signed-off-by: Pavel Karpy <[email protected]>
They are not required, only root objects can be placed to a tombstone. Signed-off-by: Pavel Karpy <[email protected]>
carpawell
force-pushed
the
fix/complex-objects-relations
branch
from
3ace6a8
to
e97444a
Compare
Added some. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.