Skip to content

Commit

Permalink
api: Fix eACL setup with multipart upload
Browse files Browse the repository at this point in the history
The removing changes was made in 70957d7#diff-efcc85eef482b2cb183da5fd07ad20378963ee903b8876f59ae2b957ee684f67L393.
The bug leads to almost infinite waiting for the waiting the result of setEACL operation.
Fixing the bug may improve/fix #800 and nspcc-dev/neofs-testcases#591.

Signed-off-by: Evgenii Baidakov <[email protected]>
  • Loading branch information
smallhive committed Aug 4, 2023
1 parent 06e8832 commit 96e0d66
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions api/handler/multipart_upload.go
Original file line number Diff line number Diff line change
Expand Up @@ -443,6 +443,12 @@ func (h *handler) CompleteMultipartUploadHandler(w http.ResponseWriter, r *http.
h.logAndSendError(w, "could not translate acl of completed multipart upload to ast", reqInfo, err, additional...)
return
}

if sessionTokenSetEACL, err = getSessionTokenSetEACL(r.Context()); err != nil {
h.logAndSendError(w, "couldn't get eacl token", reqInfo, err)
return
}

Check warning on line 450 in api/handler/multipart_upload.go

View check run for this annotation

Codecov / codecov/patch

api/handler/multipart_upload.go#L447-L450

Added lines #L447 - L450 were not covered by tests

if _, err = h.updateBucketACL(r, astObject, bktInfo, sessionTokenSetEACL); err != nil {
h.logAndSendError(w, "could not update bucket acl while completing multipart upload", reqInfo, err, additional...)
return
Expand Down

0 comments on commit 96e0d66

Please sign in to comment.