Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image build #815

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Fix image build #815

merged 1 commit into from
Aug 28, 2023

Conversation

smallhive
Copy link
Contributor

closes #814

Changing to Alpine version is required to install jq package. But this alpine image doesn't contain some important packages, thus installed them too.

Using jq also required because it formats JSON from Github request and we grep results from it

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #815 (83b17b3) into master (cb7d1e5) will not change coverage.
Report is 3 commits behind head on master.
The diff coverage is n/a.

❗ Current head 83b17b3 differs from pull request most recent head 0efeb11. Consider uploading reports for the commit 0efeb11 to get more accurate results

@@           Coverage Diff           @@
##           master     #815   +/-   ##
=======================================
  Coverage   34.33%   34.33%           
=======================================
  Files          61       61           
  Lines       10485    10485           
=======================================
  Hits         3600     3600           
  Misses       6484     6484           
  Partials      401      401           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roman-khimov
Copy link
Member

Why a merge commit here?

Changing to alpine version is required to install `jq` package. But this alpine image doesn't contain some important packages, thus installed them too.

Signed-off-by: Evgenii Baidakov <[email protected]>
@smallhive
Copy link
Contributor Author

Why a merge commit here?

Good question, fixed

@roman-khimov roman-khimov merged commit 521af4b into master Aug 28, 2023
12 checks passed
@roman-khimov roman-khimov deleted the 814-make-image-is-broken branch August 28, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make image is broken
2 participants